Skip to content

remove explicit calls to pyenv #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 9, 2025
Merged

remove explicit calls to pyenv #2004

merged 5 commits into from
Jul 9, 2025
+3 −8

Conversation

cchristous
Copy link
Member

What

This changes the Semaphore pipeline to no longer contain explicit calls to pyenv.

This approach will enable an upcoming change to Semaphore agents to replace pyenv usage with mise, which is an analogous tool that supports many different languages.

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@sonarqube-confluent

This comment has been minimized.

Sign in to view
@cchristous cchristous marked this pull request as ready for review July 2, 2025 03:27
@Copilot Copilot AI review requested due to automatic review settings July 2, 2025 03:27
@cchristous cchristous requested review from a team as code owners July 2, 2025 03:27
Copilot
Copilot AI reviewed Jul 2, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes explicit pyenv commands from the Semaphore CI pipeline to prepare for an upcoming migration to mise.

  • Eliminates manual lookup of Python versions and PATH exports across build steps
  • Relies solely on the sem-version python command to set up the Python environment

MSeal
MSeal approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied a fix for tag builds, looks good now for merge now

@sonarqube-confluent

This comment has been minimized.

Sign in to view
1 similar comment
@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (66.00% Estimated after merge)
  • Duplications No duplication information (5.20% Estimated after merge)

Project ID: confluent-kafka-python

View in SonarQube

emasab
emasab approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for @confluentinc/clients after @MSeal review

@cchristous cchristous merged commit 4bcf1a0 into master Jul 9, 2025
3 checks passed
@cchristous cchristous deleted the DP-16782 branch July 9, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@MSeal MSeal MSeal approved these changes

@emasab emasab emasab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cchristous @MSeal @emasab